[frontend + backend] added vulnerabilitties tab and 'has' relationship #8458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8458 +/- ##
=======================================
Coverage 66.04% 66.05%
=======================================
Files 597 597
Lines 60868 60871 +3
Branches 6202 6202
=======================================
+ Hits 40202 40208 +6
+ Misses 20666 20663 -3 ☔ View full report in Codecov by Sentry. |
stefan1anuby
force-pushed
the
issue/8453
branch
from
7f93a3a
to
7c1bcb4
Compare
|
Just checked your PR. The relationship creation is working well via UI and API, but there is a little miss somewhere. In SystemKnowledge.jsx, add the "has" relationshipTypes in the "related" route and it will work perfectly ! :) |
|
Would it be even better if I would create a separate route in SystemKnowledge for vulnerabilities? That also means solving #8498. |
stefan1anuby
changed the title
SarahBocognano
force-pushed
the
issue/8453
branch
from
85d2396
to
0184a80
Compare
SarahBocognano
force-pushed
the
issue/8453
branch
from
0184a80
to
f2bfcff
Compare
SarahBocognano
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added 'has' relationship between system and vulnerability:
Added 'Vulnerabilities' tab in the Knowledge sections of the Systems:
Related issues